Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ML-KEM alg_version to "FIPS203" #1997

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Set ML-KEM alg_version to "FIPS203" #1997

merged 3 commits into from
Nov 26, 2024

Conversation

SWilson4
Copy link
Member

To bring ML-KEM in line with the upcoming ML-DSA update.

Fixes #1996

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4 SWilson4 requested a review from dstebila November 19, 2024 15:34
@SWilson4 SWilson4 added this to the 0.12.0 milestone Nov 19, 2024
baentsch
baentsch reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty massive changes for 3 lines of code... Ideas why this is so?

@SWilson4
Copy link
Member Author

Pretty massive changes for 3 lines of code... Ideas why this is so?

I did wonder about this also. I generated the patch using git diff-tree as documented here. It looks to me as if the original patch was generated with git diff—when I update the patch using git diff the diff (of the diff) is much smaller, as I would have expected.

I'm fine to update the patch with git diff instead to make the changes easier to view.

@bhess
Copy link
Member

bhess commented Nov 19, 2024

Thanks @SWilson4 for updating this! You're right, the original patch was made with git diff.

@SWilson4 SWilson4 mentioned this pull request Nov 19, 2024
Merged
8 tasks
@SWilson4
Generate patch with git diff
ce4c514 
Signed-off-by: Spencer Wilson <[email protected]>
@SWilson4 SWilson4 requested a review from baentsch November 22, 2024 16:05
@dstebila
Copy link
Member

Looking for one more review @open-quantum-safe/liboqs-committers

Martyrshot
Martyrshot approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Martyrshot Martyrshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SWilson4 SWilson4 merged commit 25206cd into main Nov 26, 2024
80 checks passed
@SWilson4 SWilson4 deleted the sw-mlkem-version branch November 26, 2024 09:24
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila dstebila approved these changes

@Martyrshot Martyrshot Martyrshot approved these changes

@bhess bhess Awaiting requested review from bhess bhess is a code owner

@alexrow alexrow Awaiting requested review from alexrow alexrow is a code owner

@praveksharma praveksharma Awaiting requested review from praveksharma praveksharma is a code owner

@baentsch baentsch Awaiting requested review from baentsch baentsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Update ML-KEM alg_version to "FIPS203"
5 participants
@SWilson4 @bhess @dstebila @Martyrshot @baentsch